Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Russian translation and fix typo in Hot Seat maximum players value #8522

Merged
merged 12 commits into from
Apr 11, 2024

Conversation

Districh-ru
Copy link
Collaborator

No description provided.

@Districh-ru Districh-ru added improvement New feature, request or improvement translation Things related to languages and translations labels Mar 24, 2024
@Districh-ru Districh-ru added this to the 1.1.0 milestone Mar 24, 2024
@Districh-ru Districh-ru requested a review from Branikolog March 24, 2024 17:19
@Districh-ru Districh-ru self-assigned this Mar 24, 2024
files/lang/ru.po Outdated Show resolved Hide resolved
@Districh-ru Districh-ru requested a review from Branikolog March 27, 2024 15:24
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
@ihhub ihhub requested a review from Branikolog March 31, 2024 07:58
files/lang/ru.po Outdated Show resolved Hide resolved
@Branikolog
Copy link
Collaborator

@Districh-ru
Something is broken in this build. Application can't find data files showing the message instead of launching.

files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
@Districh-ru
Copy link
Collaborator Author

@Districh-ru Something is broken in this build. Application can't find data files showing the message instead of launching.

Interesting ... I downloaded fheroes2_windows_x64_SDL2.zip and all is OK.

@Branikolog
Copy link
Collaborator

@Districh-ru Something is broken in this build. Application can't find data files showing the message instead of launching.

Interesting ... I downloaded fheroes2_windows_x64_SDL2.zip and all is OK.

I experienced the problem on a pre-compiled build from this PR, which was ~1 hour ago. After the most recent changes the engine still can't recognize game data.
Latest commit version works fine.

@Branikolog
Copy link
Collaborator

@Districh-ru
Чтобы привести к одинаковой (безличной) форме, я бы еще предложил изменить статус хижины ведьмы
image
на "уже изучено".

@Districh-ru
Copy link
Collaborator Author

@Districh-ru Чтобы привести к одинаковой (безличной) форме, я бы еще предложил изменить статус хижины ведьмы на "уже изучено".

Done!

@ihhub ihhub requested a review from Branikolog March 31, 2024 13:35
@Branikolog
Copy link
Collaborator

Hi, @ihhub !
Could you, please, check whether the build works well here?
I've downloaded the compiled version a couple of times but each time it says there's no data found.

@ihhub
Copy link
Owner

ihhub commented Mar 31, 2024

Hi @Branikolog , it works fine for me.

@Districh-ru Districh-ru changed the title Update Russian translation and fix typo in "Enemy Speed" setting English description Update Russian translation and fix typo in English description for "Enemy Speed" setting and Hot Seat maximum players Mar 31, 2024
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
files/lang/ru.po Outdated Show resolved Hide resolved
@Districh-ru Districh-ru requested a review from Branikolog April 1, 2024 16:36
@Districh-ru Districh-ru changed the title Update Russian translation and fix typo in English description for "Enemy Speed" setting and Hot Seat maximum players Update Russian translation and fix typo in Hot Seat maximum players value Apr 3, 2024
@Districh-ru Districh-ru requested a review from ihhub April 7, 2024 12:26
@ihhub ihhub merged commit 3b41aeb into ihhub:master Apr 11, 2024
20 checks passed
@ihhub
Copy link
Owner

ihhub commented Apr 11, 2024

@Districh-ru , thank you very much for the update!

@Districh-ru Districh-ru deleted the update-russian-translation branch April 11, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants