Event code cleanup #1427
Merged
Event code cleanup #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleanup some of the event code by taking advantage of newer java 17 features - make most event types records and delete some unused events / fields - fix some intellij complaints in event usage / IGVEventBus * fix a double repaint bug in AlignmentTrack due to a missing break
This isn't really a functional change but makes it a bit easier to find/understand what event types are available.
lbergelson
commented
Oct 31, 2023
| repaint(); | ||
| break; | ||
| } | ||
| case REFRESH -> repaint(); |
There was a problem hiding this comment.
There was a silly bug here where on a RELOAD we would repaint twice since it would fall through without a break
jrobinso
pushed a commit
that referenced
this pull request
Dec 4, 2023
* Cleanup the IGV events * Cleanup some of the event code by taking advantage of newer java 17 features - make most event types records and delete some unused events / fields - fix some intellij complaints in event usage / IGVEventBus * fix a double repaint bug in AlignmentTrack due to a missing break * Cleanup ViewChange and delete ZoomChange * Make IGV events all implement sealed interface IGVEvent This isn't really a functional change but makes it a bit easier to find/understand what event types are available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to take a look at the event code a few weeks ago. I did a few things, none of them are huge changes but I think it makes them easier to use/discover and removes some boilerplate. It doesn't solve the problem of not knowing what they are meant to mean but it makes it a bit easier to discover the possible events and removes a bunch of them that were never used. Documenting what events should mean / is probably something worth looking at in the future.
Also as part of looking at this I found and fixed a bug where we were repainting AlignmentTrack twice in a row because of a missed
breakstatement.