chpmodelspec and cylindricalthermalstoragespec without storagevolumelvlmin #1046
+72
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrepetersmeier
added
code quality
2 tasks
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
src/main/scala/edu/ie3/simona/model/thermal/CylindricalThermalStorage.scala
Outdated
Show resolved
Hide resolved
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
src/test/scala/edu/ie3/simona/model/participant/ChpModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/ChpModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/ChpModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/ChpModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/ChpModelSpec.scala
Outdated
Show resolved
Hide resolved
|
@pierrepetersmeier I had a fresh look on our pair coding / problem identification from yesterday. Pleae have a very critical look on my suggestions. |
…m the original test
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
…cala Co-authored-by: Daniel Feismann <[email protected]>
…cala Co-authored-by: Daniel Feismann <[email protected]>
…cala Co-authored-by: Daniel Feismann <[email protected]>
…cala Co-authored-by: Daniel Feismann <[email protected]>
…edEnergy" and "expectedStoredEnergy" in CylindricalThermalStorageSpec.scala.
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
sebastian-peter
requested changes
Dec 10, 2024
…calthermalstoragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
…ricalthermalstoragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin' into pp/#1012-chpmodelspec-and-cylindricalthermalstoragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
sebastian-peter
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chpmodelspec and cylindricalthermalstoragespec also need adaptions for storage without storagevolumelvlmin
Resolves: #1012