Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'ChpModelSpec' and 'CylindricalThermalStorageSpec' also need adaptions for Storage without storageVolumeLvlMin #1012

Open
2 tasks
danielfeismann opened this issue Oct 30, 2024 · 0 comments · May be fixed by #1046
Open
2 tasks

'ChpModelSpec' and 'CylindricalThermalStorageSpec' also need adaptions for Storage without storageVolumeLvlMin #1012

danielfeismann opened this issue Oct 30, 2024 · 0 comments · May be fixed by #1046
Assignees
@pierrepetersmeier
Labels
test Issues related to (unit) tests

Comments

@danielfeismann
Copy link
Member

danielfeismann commented Oct 30, 2024 •
edited
Loading 

          'ChpModelSpec' and 'CylindricalThermalStorageSpec' also need adaptions for Storage without storageVolumeLvlMin

Originally posted by @danielfeismann in #895 (comment)

to do's

  • Set storageVolumeLvlMin to zero (later, when PSDM update will be released this entry will be removed)
  • Adapt tests accordingly
@danielfeismann danielfeismann added the test Issues related to (unit) tests label Oct 30, 2024
@pierrepetersmeier pierrepetersmeier self-assigned this Oct 30, 2024
@pierrepetersmeier pierrepetersmeier linked a pull request Nov 22, 2024 that will close this issue
chpmodelspec and cylindricalthermalstoragespec without storagevolumelvlmin #1046
Open
@pierrepetersmeier pierrepetersmeier linked a pull request Nov 22, 2024 that will close this issue
Open
pierrepetersmeier added a commit that referenced this issue Nov 22, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#1012-chpmodelspec-and-cylindricalthermals…
9339ffc 
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
pierrepetersmeier added a commit that referenced this issue Nov 22, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#1012-chpmodelspec-and-cylindricalthermals…
fbf8c4b 
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
pierrepetersmeier added a commit that referenced this issue Nov 27, 2024
@pierrepetersmeier
Merge branch 'dev' into pp/#1012-chpmodelspec-and-cylindricalthermals…
75b1ac7 
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
danielfeismann added a commit that referenced this issue Nov 29, 2024
@danielfeismann
Merge branch 'dev' into pp/#1012-chpmodelspec-and-cylindricalthermals…
bfcd012 
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
danielfeismann added a commit that referenced this issue Dec 3, 2024
@danielfeismann
Merge branch 'dev' into pp/#1012-chpmodelspec-and-cylindricalthermals…
5b35371 
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
sebastian-peter added a commit that referenced this issue Dec 10, 2024
@sebastian-peter
Merge branch 'dev' into pp/#1012-chpmodelspec-and-cylindricalthermals…
53fd19e 
…toragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
danielfeismann added a commit that referenced this issue Dec 10, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into pp/#1012-chpmodelspec-and-cylindri…
0bb6620 
…calthermalstoragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
danielfeismann added a commit that referenced this issue Dec 10, 2024
@danielfeismann
Merge remote-tracking branch 'origin/pp/#1012-chpmodelspec-and-cylind…
7fa5bbb 
…ricalthermalstoragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin' into pp/#1012-chpmodelspec-and-cylindricalthermalstoragespec-also-need-adaptions-for-storage-without-storagevolumelvlmin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierrepetersmeier pierrepetersmeier

Labels
test Issues related to (unit) tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chpmodelspec and cylindricalthermalstoragespec without storagevolumelvlmin ie3-institute/simona
2 participants
@danielfeismann @pierrepetersmeier