Skip to content

Commit

Permalink
[FIX] Fixed an issue with ic_splash causing crashes because `gradie…
Browse files Browse the repository at this point in the history
…nt` in not supported in android below `API` `24`
iZakirSheikh committed Nov 11, 2024
1 parent 4b81115 commit 6370a29
Showing 9 changed files with 19 additions and 51 deletions.
38 changes: 3 additions & 35 deletions .idea/appInsightsSettings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions .idea/deploymentTargetSelector.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -65,8 +65,8 @@ android {
applicationId = "com.prime.player"
minSdk = 21
targetSdk = 35
versionCode = 158
versionName = "3.0.0"
versionCode = 159
versionName = "3.0.1"
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables { useSupportLibrary = true }
// init different config fields.
2 changes: 1 addition & 1 deletion app/src/main/java/com/prime/media/MainActivity.kt
Original file line number Diff line number Diff line change
@@ -736,7 +736,7 @@ class MainActivity : ComponentActivity(), SystemFacade, OnDestinationChangedList
if (savedVersionCode != versionCode) {
preferences[KEY_APP_VERSION_CODE] = versionCode
showToast(
R.string.what_s_new_latest,
R.string.what_s_new_toast,
duration = Toast.DURATION_INDEFINITE,
icon = Icons.Outlined.Whatshot
)
File renamed without changes.
Binary file added app/src/main/res/drawable/ic_splash.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions app/src/main/res/values/what_s_new.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>

<string name="what_s_new_toast" translatable="false">
<b>What\'s new</b>
<font color='grey'>
\n🐞 Resolved a critical issue causing crashes on devices running Android 7 and below.
</font>
</string>

<string name="what_s_new_latest" translatable="false">
<b>What\'s new</b>
<font color='grey'>
@@ -9,6 +17,7 @@
\n✨ Toasts &amp; <b>SnackBars</b> got a boost! Swipe to dismiss, expand for more info, and enjoy smoother interactions.
\n✨ New <b>Playlists, Personalization, Settings, Albums</b> and other screens.
\n\n<b>Bug Fixes:</b>
\n🐞 Resolved a critical issue causing crashes on devices running Android 7 and below
\n🐞 Fixed some bugs causing crashes in some devices.
\n🐞 Fixed a <b>bug</b> causing <b>albums</b> to lose state once navigated away from them.
\n🐞 Resolved an issue causing the screen to dim during video playback mode.
8 changes: 4 additions & 4 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ agp = "8.7.2"
kotlin = "2.0.21"
compose = "1.8.0-alpha05"
media3 = "1.4.1"
toolkit = "2.0.2"
toolkit = "2.1.0"
material_icons = "1.7.5"
room = "2.6.1"

@@ -41,7 +41,7 @@ androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version = "1.1
navigation-compose = { module = "androidx.navigation:navigation-compose", version = "2.8.3" }
androidx-koin = { module = "io.insert-koin:koin-androidx-compose", version = "4.0.0" }
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version = "1.9.0" }
androidx-annotation-jvm = { group = "androidx.annotation", name = "annotation-jvm", version = "1.9.0" }
androidx-annotation-jvm = { group = "androidx.annotation", name = "annotation-jvm", version = "1.9.1" }

# Accompanist
accompanist-permissions = { module = "com.google.accompanist:accompanist-permissions", version = "0.36.0" }
@@ -86,11 +86,11 @@ androidx-activity-compose = { group = "androidx.activity", name = "activity-comp
androidx-core-splashscreen = { module = "androidx.core:core-splashscreen", version = "1.0.1" }
androidx-startup-runtime = { module = "androidx.startup:startup-runtime", version = "1.2.0" }
lottie-compose = { module = "com.airbnb.android:lottie-compose", version = "6.6.0" }
chrisbanes-haze = {module= "dev.chrisbanes.haze:haze", version = "0.9.0-rc01"}
chrisbanes-haze = {module= "dev.chrisbanes.haze:haze", version = "1.0.0"}

# Google Play Services
play-app-update-ktx = { module = "com.google.android.play:app-update-ktx", version = "2.1.0" }
play-app-review-ktx = { module = "com.google.android.play:review-ktx", version = "2.0.1" }
play-app-review-ktx = { module = "com.google.android.play:review-ktx", version = "2.0.1" } #Updating it caused crash on 2.0.2
google-billing-ktx = { module = "com.android.billingclient:billing-ktx", version = "7.1.1" }
play_feature_delivery = { module = "com.google.android.play:feature-delivery-ktx", version = "2.1.0" }

0 comments on commit 6370a29

Please sign in to comment.