Skip to content

Commit

Permalink
[CHORE] Updated some dependencies to latest versions.
Browse files Browse the repository at this point in the history
[FIX] Fixed a bug causing crash in TagEditorViewModel.kt when the file type passed is not Mp3
  • Loading branch information
iZakirSheikh committed Nov 7, 2024
1 parent 9d69c2e commit 4b81115
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 21 deletions.
34 changes: 33 additions & 1 deletion .idea/appInsightsSettings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ android {
applicationId = "com.prime.player"
minSdk = 21
targetSdk = 35
versionCode = 157
versionName = "3.0.0-rc03"
versionCode = 158
versionName = "3.0.0"
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables { useSupportLibrary = true }
// init different config fields.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,11 @@ class TagEditorViewModel constructor(
init {
viewModelScope.launch {
// requires new name
file = Mp3File(path ?: throw IllegalArgumentException("$path must not be null"))
val result = runCatching { initialize() }
//file = Mp3File(path ?: throw IllegalArgumentException("$path must not be null"))
val result = runCatching {
file = Mp3File(path ?: error("path must not be null"))
initialize()
}
// show error message if there happened an error during initializing phase
if (result.isFailure)
snackbar.showToast("${result.exceptionOrNull()?.message}")
Expand Down
18 changes: 6 additions & 12 deletions app/src/main/res/values/what_s_new.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,16 @@
<string name="what_s_new_latest" translatable="false">
<b>What\'s new</b>
<font color='grey'>
\n <b>New Features</b>
✨ Added a feature allowing users to make the <b>navigation bar</b> use <b>accent</b> color.
✨ Toasts &amp; <b>SnackBars</b> got a boost! Swipe to dismiss, expand for more info, and enjoy smoother interactions.
✨ New <b>Playlists, Personalization, Settings, Albums</b> and other screens.
\n <b>Celebrating </b> Our Exciting 3.0.0 Release!💐
\n\n <b>New Features</b>
\n✨ Added a feature allowing users to make the <b>navigation bar</b> use <b>accent</b> color.
\n✨ Toasts &amp; <b>SnackBars</b> got a boost! Swipe to dismiss, expand for more info, and enjoy smoother interactions.
\n✨ New <b>Playlists, Personalization, Settings, Albums</b> and other screens.
\n\n<b>Bug Fixes:</b>
\n🐞 Minor Bug Fixes
\n🐞 Fixed some bugs causing crashes in some devices.
\n🐞 Fixed a <b>bug</b> causing <b>albums</b> to lose state once navigated away from them.
\n🐞 Resolved an issue causing the screen to dim during video playback mode.
\n\n<b>In Focus</b>
\n ⦿ General performance improvements
\n ⦿ Added support for in-app <b>Video Browser</b> and <b>RecycleBin</b>
\n ⦿ Enhanced with <b>Noise Cancellation, Widgets,</b> and more <b>in-app Widgets</b>
\nPlease keep supporting by sponsoring us or rating us in <b>Playstore</b>.
\n\nThanks Team <b><i>Audio</i></b>.
</font>

</string>


Expand Down
8 changes: 4 additions & 4 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ agp = "8.7.2"
kotlin = "2.0.21"
compose = "1.8.0-alpha05"
media3 = "1.4.1"
toolkit = "2.0.2-rc04"
toolkit = "2.0.2"
material_icons = "1.7.5"
room = "2.6.1"

Expand All @@ -27,17 +27,17 @@ androidx-foundation = { module = "androidx.compose.foundation:foundation", versi
androidx-animation-graphics = { module = "androidx.compose.animation:animation-graphics", version.ref = "compose" }

# Misc
androidx-ui-text-google-fonts = { module = "androidx.compose.ui:ui-text-google-fonts", version = "1.7.4" }
androidx-ui-text-google-fonts = { module = "androidx.compose.ui:ui-text-google-fonts", version = "1.7.5" }
coil-compose = { module = "io.coil-kt:coil-compose", version = "2.7.0" }
kenburnsview = { module = "com.flaviofaria:kenburnsview", version = "1.0.7" }
wavy-slider = { module = "ir.mahozad.multiplatform:wavy-slider", version = "1.3.0" }
androidx-palette-ktx = { module = "androidx.palette:palette-ktx", version = "1.0.0" }
androidx-graphics-shapes = { module = "androidx.graphics:graphics-shapes", version = "1.0.1" }
androidx-constraint-layout-compose = { module = "androidx.constraintlayout:constraintlayout-compose", version = "1.0.1" }
androidx-constraint-layout-compose = { module = "androidx.constraintlayout:constraintlayout-compose", version = "1.1.0" }
# TODO - Remove this when widgets are replaced by compose glance.
material_view = { module = "com.google.android.material:material", version = "1.12.0" }
androidx-biometric-ktx = { module = "androidx.biometric:biometric-ktx", version = "1.4.0-alpha02" }
androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version = "1.13.1" }
androidx-core-ktx = { group = "androidx.core", name = "core-ktx", version = "1.15.0" }
navigation-compose = { module = "androidx.navigation:navigation-compose", version = "2.8.3" }
androidx-koin = { module = "io.insert-koin:koin-androidx-compose", version = "4.0.0" }
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version = "1.9.0" }
Expand Down

0 comments on commit 4b81115

Please sign in to comment.