Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove drafts from Ready column #394

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Remove drafts from Ready column #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/pull.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export class Pull extends PullData {
isReady(): boolean {
return (
this.hasMetDeployRequirements() &&
!this.isDraft() &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be in the hasMetDeployRequirements function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We consider a draft as a type of dev-block so I think it would be best grouped with the other conditions that check for blocks

      !this.isDraft() &&
      !this.getDevBlock() &&
      !this.getDeployBlock() &&

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be better to group those into their own hasBlock() function

!this.getDevBlock() &&
!this.getDeployBlock() &&
!this.hasMergeConflicts()
Expand Down
Loading