Remove drafts from Ready column #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will remove pull requests that are drafts out of the 'Ready' column
mlahargou
reviewed
Oct 17, 2023
| @@ -123,6 +123,7 @@ export class Pull extends PullData { | |||
| isReady(): boolean { | |||
| return ( | |||
| this.hasMetDeployRequirements() && | |||
| !this.isDraft() && | |||
There was a problem hiding this comment.
Maybe this should be in the hasMetDeployRequirements function?
There was a problem hiding this comment.
We consider a draft as a type of dev-block so I think it would be best grouped with the other conditions that check for blocks
!this.isDraft() &&
!this.getDevBlock() &&
!this.getDeployBlock() &&
There was a problem hiding this comment.
It may be better to group those into their own hasBlock() function
|
CR 👍 but I wouldn't oppose another PR to clean up the functions some way or other. |
deltuh-vee
added
QAing
|
@kthaler I resolved the external block if you'd like to test this one out |
|
QA 🎬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will filter out draft pull requests out from the Ready column
Closes #393