Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic([]byte base) signer interface #142

Merged
merged 3 commits into from
Jun 13, 2024
Merged

add generic([]byte base) signer interface #142

merged 3 commits into from
Jun 13, 2024

Conversation

dai1975
Copy link
Contributor

@dai1975 dai1975 commented Jun 4, 2024

add generic([]byte base) signer interface

@dai1975 dai1975 requested a review from a team as a code owner June 4, 2024 09:57
@dai1975 dai1975 mentioned this pull request Jun 4, 2024
Merged
@siburu
Copy link
Contributor

siburu commented Jun 9, 2024 •
edited
Loading

@dai1975 Thank you and I'm sorry for late reply.

Could you make yui-relayer/signer directory and move signer.go into it? The reason is that Signer is not related to the core functionality of yui-relayer.

@dai1975
Copy link
Contributor Author

dai1975 commented Jun 10, 2024

Sure. I've done to move to signer package.

siburu
siburu approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@siburu siburu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dai1975 LGTM. Thank you!

@siburu siburu merged commit 529049a into hyperledger-labs:main Jun 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siburu siburu siburu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dai1975 @siburu