use generic signer interface #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
siburu
reviewed
Jul 2, 2024
Comment on lines
+44
to
+46
| func (s *EthereumSigner) SetLogger(logger *log.RelayLogger) { | ||
| s.logger = logger | ||
| } |
There was a problem hiding this comment.
After calling SetLogger and finishing the processing, we need to reset the logger, right?
origLogger := c.ethereumSigner.GetLogger()
c.ethereumSigner.SetLogger(newLogger)
<... some processing ...>
c.ethereumSigner.SetLogger(origLogger)
or
c.ethereumSigner.PushLogger(newLogger)
<... some processing ...>
defer c.ethereumSigner.PopLogger()
In any case, we should define an interface that clearly indicates the section where the configured logger is used.
There was a problem hiding this comment.
This EthereumSigner use logger only in Sign function and no need to have dedicate logger instance(such like use different output log file).
How abount Sign function get logger or ctx which has logger as an arument?
func (s *EthereumSigner) Sign(address common.Address, tx *gethtypes.Transaction, logger *log.RelayLogger) (*gethtypes.Transaction, error) {
There was a problem hiding this comment.
I see.
fixed by using defer SetLogger(oldlogger) pattern in tx.go
Signed-off-by: Daisuke Kanda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ethereum signer with bytes[] signer interface added in hyperledger-labs/yui-relayer#142