Watch downloads #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 10, 2020
Frando
force-pushed
the
watch-downloads
branch
from
c8cf5c3 to
048dd48
Compare
Open
|
CI fails because this depends on the two PR linked through the references. Not sure if there's a nice way to run CI for such interdependent PRs. |
2 tasks
Frando
force-pushed
the
watch-downloads
branch
from
048dd48 to
787ee22
Compare
mafintosh
reviewed
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to watch downloads. It adds
watchDownloadsandunwatchDownloadsmethods to the hypercore service. If watching downloads,onDownloadis called towards the client for each downloaded block. Only theseqis transferred, not the full block. Download events are disabled by default, to skip the overhead for clients that don't need them.This is a part of #2 and a step towards running kappa-style apps on top of hyperspace, especially for indexing sparsely synced hypercores in live mode.
Instead of adding
watchDownloadsandunwatchDownloadsmethods I was also considering of adding a singleoptionsmethod with aOptionsRequest { bool watchDownloads = 1 }. When/if other session options came along that could make this more straightforward instead of adding getters and setters for each option - not sure though.