Watch downloads #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Instead of adding two new methods couldn’t we trigger this when a new download listener has been added? |
Frando
force-pushed
the
watch-downloads
branch
from
d82b791 to
09c45f9
Compare
|
@mafintosh I removed the two methods and now it just works by registering an event listener for the |
Frando
force-pushed
the
watch-downloads
branch
from
09c45f9 to
55da6f3
Compare
Frando
force-pushed
the
watch-downloads
branch
from
55da6f3 to
fbff468
Compare
mafintosh
reviewed
Sep 16, 2020
mafintosh
reviewed
Sep 16, 2020
mafintosh
reviewed
Sep 16, 2020
mafintosh
reviewed
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to hypercore-protocol/hyperspace#5, see there for details.