Fix Inconsistency with IsShardedQLoRA Setting #2089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In huggingface/transformers#33154, logic was introduced to fix
low_cpu_mem_mode
, in which the weights will be accordingly moved to eithercpu
ormeta
device depending on device rank. However, this causes a problem here asis_sharded_qlora
could then be potentially set toTrue
on device0
andFalse
on all others.This PR fixes this problem which will be experienced in the upcoming transformers release.
Fixes transformers#33154
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
@mdouglas
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.