build(deps): unset hardcoded trl version to get latest updates #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anh Uong <[email protected]>
|
Thanks for making a pull request! 😃 |
|
this one is needed to get my QloRA fix huggingface/trl#2089 |
2 tasks
|
@fabianlim although your PR into trl was merged last week Sep 21st, it doesn't appear to be in the latest release as seen from the commit history |
|
@anhuong its in main, but not released in 0.11.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Previousl in PR #329 we had hardcoded release branch to be v0.9.6 of trl but we want to unset the hardcoded version to get updates since we fixed the error with pretokenized datasets on main branch.
Related issue number
How to verify the PR
Was the PR tested