Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agents: Small fixes in streaming to gradio + add tests #34549

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

aymeric-roucher
Copy link
Contributor

What does this PR do?

Merge stream_run and direct_run in one more elegant function to streamline the code.

@aymeric-roucher aymeric-roucher force-pushed the agents-merge-run-versions-stream-and-direct branch from 1659e66 to 075eea5 Compare October 31, 2024 22:22
@aymeric-roucher aymeric-roucher force-pushed the agents-merge-run-versions-stream-and-direct branch from 075eea5 to b438e6a Compare October 31, 2024 22:23
@aymeric-roucher aymeric-roucher marked this pull request as ready for review October 31, 2024 22:23
@aymeric-roucher
Copy link
Contributor Author

Note to self: my attempt to unify a stream_run function that yields results as they come and the direct_run function was misled: inserting even the tyniest yield in a function turns it into a generator, which I don't want for my run function.
Since this PR has nice monitoring tests and improvements, I'll still keep it with only these bits!

@aymeric-roucher aymeric-roucher force-pushed the agents-merge-run-versions-stream-and-direct branch 3 times, most recently from 67407ee to 230656d Compare November 4, 2024 17:36
@aymeric-roucher aymeric-roucher changed the title Agents: Merge stream_run and direct_run into the run function Agents: Small fixes in streaming to gradio + add tests Nov 4, 2024
@aymeric-roucher aymeric-roucher force-pushed the agents-merge-run-versions-stream-and-direct branch 3 times, most recently from 99477b8 to c66eb31 Compare November 4, 2024 17:46
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aymeric-roucher aymeric-roucher force-pushed the agents-merge-run-versions-stream-and-direct branch 4 times, most recently from 35af006 to 82187e0 Compare November 11, 2024 19:01
@aymeric-roucher aymeric-roucher force-pushed the agents-merge-run-versions-stream-and-direct branch from 82187e0 to 05996e4 Compare November 11, 2024 19:03
@aymeric-roucher aymeric-roucher force-pushed the agents-merge-run-versions-stream-and-direct branch from 609d82a to 33f0bfd Compare November 11, 2024 19:42
@aymeric-roucher aymeric-roucher merged commit 33eef99 into main Nov 11, 2024
13 checks passed
@aymeric-roucher aymeric-roucher deleted the agents-merge-run-versions-stream-and-direct branch November 11, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants