Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish environments #120

Merged
merged 2 commits into from
May 3, 2024
Merged

Publish environments #120

merged 2 commits into from
May 3, 2024

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented Apr 30, 2024 •
edited
Loading

What this does

Remove environments as git dependencies and use their pypi published package instead

TODO before this is ready:

@aliberts aliberts changed the title User/aliberts/2024 04 30 publish envs [WIP] Publish environments Apr 30, 2024
@aliberts aliberts added the ➡️ Dependencies Adding, removing or updating dependencies label Apr 30, 2024
@aliberts aliberts self-assigned this Apr 30, 2024
@aliberts aliberts force-pushed the user/aliberts/2024_04_30_publish_envs branch from d37f231 to df3cead Compare May 3, 2024 13:58
@aliberts aliberts marked this pull request as ready for review May 3, 2024 14:07
@aliberts aliberts requested a review from Cadene May 3, 2024 14:07
Cadene
Cadene approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a champ

@aliberts aliberts changed the title [WIP] Publish environments Publish environments May 3, 2024
@aliberts aliberts merged commit b7b69fc into main May 3, 2024
4 checks passed
@aliberts aliberts deleted the user/aliberts/2024_04_30_publish_envs branch May 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-soare alexander-soare alexander-soare approved these changes

@Cadene Cadene Cadene approved these changes

Assignees

@aliberts aliberts

Labels
➡️ Dependencies Adding, removing or updating dependencies
Projects
Le Robot TODO
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliberts @Cadene @alexander-soare