Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast "threshold" from Int type to long type #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cast "threshold" from Int type to long type #139

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c11f7a4
Cast "threshold" from Int type to long type
yuna-yano Jan 15, 2018
2fbebcd
Changed argument to long type.
yuna-yano Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/main/java/hotchemi/android/rate/AppRate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public static boolean showRateDialogIfMeetsConditions(Activity activity) {
}

private static boolean isOverDate(long targetDate, int threshold) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess changing the type of second argument as long is simpler solution, what do you think?

Copy link
Author

@yuna-yano yuna-yano Feb 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review.
That's good! I will fix that way.

return new Date().getTime() - targetDate >= threshold * 24 * 60 * 60 * 1000;
return new Date().getTime() - targetDate >= (long)threshold * 24 * 60 * 60 * 1000;
}

public AppRate setLaunchTimes(int launchTimes) {
Expand Down