Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast "threshold" from Int type to long type #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cast "threshold" from Int type to long type #139

wants to merge 2 commits into from

Conversation

yuna-yano
Copy link

It corresponds to issue #138.

hotchemi
hotchemi reviewed Feb 6, 2018
View reviewed changes
library/src/main/java/hotchemi/android/rate/AppRate.java Outdated
@@ -54,7 +54,7 @@ public static boolean showRateDialogIfMeetsConditions(Activity activity) {
}

private static boolean isOverDate(long targetDate, int threshold) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess changing the type of second argument as long is simpler solution, what do you think?

Copy link
Author

@yuna-yano yuna-yano Feb 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review.
That's good! I will fix that way.

@yuna-yano yuna-yano force-pushed the threshold_cast_to_long branch from 4e55df6 to 2fbebcd Compare February 20, 2018 03:13
@hotchemi
Copy link
Owner

Thx and LGTM! Let me look into CI.

@AlexanderLS
Copy link

AlexanderLS commented Mar 9, 2018 •
edited
Loading

@yuna-yano your commits were merged into https://github.com/Vorlonsoft/AndroidRate/ (Releases 1.0.9+)

@yuna-yano
Copy link
Author

yuna-yano commented Mar 13, 2018 •
edited
Loading

@hotchemi
In Travis CI, it seems that an error appears with the following command.

$ echo no | android create avd --force -n test -t android-21 --abi armeabi-v7a
Error: Target id is not valid. Use 'android list targets' to get the target ids.

When searching, Issue like this came out.

travis-ci/travis-ci#6606

I think this is a problem of the CI environment.

It is another repository, but for reference.
play-co/devkit#19

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotchemi hotchemi hotchemi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuna-yano @hotchemi @AlexanderLS