Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rest of sensors for HHCCJCY01 #75646

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Jul 23, 2022

Proposed change

This expands on #75618 to fully support the passive sensors on the HHCCJCY01 (including the most important for a plant sensor - moisture).

This will solve most of #74585 (more work is needed to get battery for these devices - its not in the broadcasts).

Screenshot 2022-07-23 at 08 44 56

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Ernst79, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_ble) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@Jc2k Jc2k changed the title Add rest of sensors for HHCCJCY01 Add support for rest of sensors for HHCCJCY01 Jul 23, 2022
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there may be a small breaking changing coming via #75642

@Jc2k Jc2k merged commit b60a592 into home-assistant:dev Jul 23, 2022
@Jc2k Jc2k deleted the xiaomi_ble_hhccjcy01 branch July 23, 2022 08:40
@@ -68,6 +76,20 @@
state_class=SensorStateClass.MEASUREMENT,
entity_registry_enabled_default=False,
),
# Used for e.g. moisture sensor on HHCCJCY01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Candidate for a new sensor device class? I count 7 existing integrations that have moisture sensors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I'll add it to my todo.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants