Modified arlo object to make smarter HTTP requests for an async envir… #13445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onment (conn pool, blocking)
homeassistant
added
cla-needed
integration: arlo
small-pr
houndci-bot
reviewed
Mar 25, 2018
homeassistant/components/arlo.py
Outdated
| @@ -43,6 +44,7 @@ def setup(hass, config): | |||
| from pyarlo import PyArlo | |||
|
|
|||
| arlo = PyArlo(username, password, preload=False) | |||
| arlo.session.mount('https://',HTTPAdapter(pool_maxsize=10,pool_block=True)) | |||
There was a problem hiding this comment.
missing whitespace after ','
line too long (83 > 79 characters)
trailing whitespace
houndci-bot
reviewed
Mar 25, 2018
homeassistant/components/arlo.py
Outdated
| @@ -43,6 +44,8 @@ def setup(hass, config): | |||
| from pyarlo import PyArlo | |||
|
|
|||
| arlo = PyArlo(username, password, preload=False) | |||
| arlo.session.mount('https://', | |||
| HTTPAdapter(pool_maxsize=10, pool_block=True)) | |||
There was a problem hiding this comment.
continuation line under-indented for visual indent
|
No description 🤔 |
|
This also looks like something that needs to be fixed upstream in the pyarlo package. |
|
Ok. This was the related issue #13176 |
|
We should fix this upstream. If upstream package is dead as the other issue describes, we should switch package to one with an active maintainer. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onment (conn pool, blocking)
Description:
Related issue (if applicable): fixes #13176
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: