Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HassClimateSetTemperature intent #134316

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Dec 30, 2024

Proposed change

This adds the HassClimateSetTemperature intent which allows to set the temperature of a climate entity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of climate can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign climate Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mib1185 mib1185 marked this pull request as draft December 31, 2024 00:33
@mib1185 mib1185 marked this pull request as ready for review December 31, 2024 10:17
Copy link
Contributor Author

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The set_temperature action call does not take the temperature unit as field, so I think we could also keep it out of the intent definition in https://github.com/home-assistant/intents/blob/3bbc6bc34f2295aa82efccf99a0de3e8b3d35949/intents.yaml#L234-L250

Another solution would be to extend the set_temperature action call to take optional the unit and make conversations within it.

@mib1185
Copy link
Contributor Author

mib1185 commented Dec 31, 2024

is it ok to add the temperature_unit field for the set_temperature action here or should we split it into a separate PR?

Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to use different arguments than other intents which may be confusing to voice assistants and LLMs. Can this use the same standard set used by other intents? e.g. names and areas etc.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 31, 2024 20:32
@mib1185
Copy link
Contributor Author

mib1185 commented Dec 31, 2024

It uses the common name and area arguments (as part of the intent.ServiceIntentHandler), further it uses some specific arguments, which are defined in the intent definition (see #134316 (review))

@mib1185 mib1185 marked this pull request as ready for review December 31, 2024 20:49
@home-assistant home-assistant bot requested a review from allenporter December 31, 2024 20:49
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry misread the tests (misunderstood new tests calling a service as the intent test)

@MartinHjelmare MartinHjelmare marked this pull request as draft January 1, 2025 07:21
@allenporter
Copy link
Contributor

I think we could also keep it out of the intent definition in https://github.com/home-assistant/intents/blob/3bbc6bc34f2295aa82efccf99a0de3e8b3d35949/intents.yaml#L234-L250

Seems like the proposal can stand without including this, so maybe separate? (When I ask the assistant today about the temperature it seems to work out without any unit"what is the temperature in the dining room?" it replies "68 degrees" and seems to work fine without any)

@mib1185 mib1185 marked this pull request as ready for review January 2, 2025 15:33
@home-assistant home-assistant bot requested a review from allenporter January 2, 2025 15:33
@mib1185
Copy link
Contributor Author

mib1185 commented Jan 2, 2025

In favor of home-assistant/architecture#1177 I've reverted the addition of the temperature unit (so the code still is available in the commits for a properly later use).
So this PR adds the HassClimateSetTemperature based on the climate.set_temperature action as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants