-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HassClimateSetTemperature intent #134316
base: dev
Are you sure you want to change the base?
Add HassClimateSetTemperature intent #134316
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The set_temperature
action call does not take the temperature unit as field, so I think we could also keep it out of the intent definition in https://github.com/home-assistant/intents/blob/3bbc6bc34f2295aa82efccf99a0de3e8b3d35949/intents.yaml#L234-L250
Another solution would be to extend the set_temperature
action call to take optional the unit and make conversations within it.
is it ok to add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to use different arguments than other intents which may be confusing to voice assistants and LLMs. Can this use the same standard set used by other intents? e.g. names and areas etc.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
It uses the common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry misread the tests (misunderstood new tests calling a service as the intent test)
Seems like the proposal can stand without including this, so maybe separate? (When I ask the assistant today about the temperature it seems to work out without any unit"what is the temperature in the dining room?" it replies "68 degrees" and seems to work fine without any) |
This reverts commit c27dcbc.
In favor of home-assistant/architecture#1177 I've reverted the addition of the temperature unit (so the code still is available in the commits for a properly later use). |
Proposed change
This adds the
HassClimateSetTemperature
intent which allows to set the temperature of aclimate
entity.Type of change
Additional information
temperature_unit
in climatesset_temperature
action call home-assistant.io#36625Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: