Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeout from Russound RIO initialization #134070

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

noahhusby
Copy link
Contributor

Proposed change

⚠️ Please add to 2025.1 milestone. Resolves a crucial issue preventing users with 3+ controllers from connecting

Timeouts have been removed from the integration as they have been implemented in the upstream library.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@elupus
Copy link
Contributor

elupus commented Dec 27, 2024

This change is fine. However. You have a new 5 second timeout in the library. That is way too short (i know it is only for connect). With any smal network disruption or loaded home assistant that will timeout.

Even 30 seconds is on the low side for network connections. It is only asking for trouble.

@elupus elupus added this to the 2025.1.0 milestone Dec 27, 2024
@elupus elupus merged commit ad89004 into home-assistant:dev Dec 27, 2024
34 checks passed
@noahhusby noahhusby deleted the fix/russound-remove-timeout branch December 27, 2024 14:53
sorgfresser pushed a commit to sorgfresser/homeassistant-core that referenced this pull request Dec 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants