feat: Add Installer login, Add ManualCharge Switch #133773
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @stegm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
| @@ -21,6 +21,7 @@ | |||
| { | |||
| vol.Required(CONF_HOST): str, | |||
| vol.Required(CONF_PASSWORD): str, | |||
| vol.Optional("Service Code"): str, | |||
There was a problem hiding this comment.
Consider adding a constant for the service code (used multiple times)
There was a problem hiding this comment.
Where is the best place to add it? In const.py of kostal_plenticore?
| @@ -33,7 +34,7 @@ async def test_connection(hass: HomeAssistant, data) -> str: | |||
|
|
|||
| session = async_get_clientsession(hass) | |||
| async with ApiClient(session, data["host"]) as client: | |||
| await client.login(data["password"]) | |||
| await client.login(data["password"], service_code=data.get("Service Code")) | |||
There was a problem hiding this comment.
Use CONF_PASSWORD for "password"
Proposed change
This change makes it possible to use a installer login with kostal plenticore. It enables access to more settings that are not available from the normal login. The change also adds the ManualCharge Switch which activates Service Charging. This Switch can only be set when the installer login is active.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: