Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload on connection lost for LCN integration #133638

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

alengwenus
Copy link
Contributor

@alengwenus alengwenus commented Dec 20, 2024

Proposed change

The LCN integration is reloaded if the connection to the hardware bus is lost or the socket to the host coupler is lost/unresponsive.
Detection of unavailability is done using events which are fired by the underlying interface library (pypck).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor

epenet commented Dec 20, 2024

Can you make the dependency bump a preliminary PR?

@alengwenus alengwenus marked this pull request as draft December 20, 2024 12:06
@alengwenus
Copy link
Contributor Author

Can you make the dependency bump a preliminary PR?

Done: #133646
I set this PR to draft and will rebase it once the dependency update is merged.

@alengwenus alengwenus marked this pull request as ready for review December 20, 2024 16:48
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @alengwenus 👍

../Frenck

@frenck frenck merged commit 74b425a into home-assistant:dev Dec 22, 2024
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LCN Integration Crashes after few days
3 participants