-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple sections #131393
base: dev
Are you sure you want to change the base?
Allow multiple sections #131393
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
606771d
to
71d881f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide an overview of use cases and existing integrations that can use the new selector config, besides the compensation integration.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I have updated the PR description with some integrations that could use this. There are probably also quite a few more than could use it, if it was available when it went into UI. |
I'd say that of the ones mentioned now, only bayesian, compensation and filter are suitable. Scrape would use sub entries (nuggets), and template alarm control panel I don't see how it would use a multiple section. There's only one action (script) allowed per alarm control panel service action and panel and we use action selectors for that. |
I was more thinking the whole arming definition would go into sections. So instead as currently you need to ask which ones to use and present on a second form. The user could just simply add one after the other and define for which action it is. So I think that would also be the same for arm_away:
action: alarm_control_panel.alarm_arm_away
target:
entity_id: alarm_control_panel.real_alarm
data:
code: !secret alarm_code |
What's the second form? Is it really intuitive to use sections when there's a limited set of distinct items to configure? |
I guess that's a border line case to have the sections in the initial form (and the user need to select the arming types) than presenting the fixed set of options on a second form (or multiple forms). |
There's only one form for template alarm control panel. |
I don't remember but I guessed two. Anyhow template is not the best example here anyhow. |
Proposed change
Allow us to use multiple sections e.g. the user can add/remove sections from the same configuration.
See frontend PR how it would be displayed for the user.
Example of integrations that could use this (some already in UI)
bayesian
(observations list)filter
(as filters)compensation
(data points)template
(alarm_control_panel/lock define the different arming/lock options).scrape
(sensors)Frontend: home-assistant/frontend#22965
Dev docs: home-assistant/developers.home-assistant#2471
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: