Add support for Shelly BLU TRV #128439
Add support for Shelly BLU TRV #128439
Conversation
home-assistant
bot
added
cla-signed
Hacktoberfest
integration: shelly
new-feature
labels
|
Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
@chemelli74 Is this still in progress? Because PR is marked as Draft. |
Hi @leptoquark1 yes it's in progress. But we need some firmware changes from Shelly and we are waiting for them. |
|
Can you link this PR with the relevant Issue or PR? |
? |
Sorry I misread your answer, thinking you ment any hass core changes. However, is there a thread or something of whats missing, further steps and/or issues of involved parties? I think the currently missing api-docs of the new products would help here, where the available RPC methods are exposed in detail. There is a workaround with RPC via MQTT or rest-command to extend, for example, the compatibility with other external temperature sensors, but the BLE Gen3 ones. |
I think this is a good place to discuss support for BLU TRV, not this PR https://community.home-assistant.io/t/new-shelly-trv-blu-integration/777837 |
I'm not sure if the community forum is the right spot for technical discussions. It is, unlike this PR, not linked to the code changes. I asked about details of the firmware restrictions that block this PR. For any possible contributors its not accessible just by this PR and therefore not clear why the PR seems stale. However. I assume that it was not possible to control the valve position using the public API. That looks patched in v1.1.1 and is now documented here: |
| mode = hvac_mode in (HVACMode.COOL, HVACMode.HEAT) | ||
| await self.call_rpc( | ||
| "BluTRV.Call", | ||
| { | ||
| "id": self._id, | ||
| "method": "Trv.SetConfig", | ||
| "params": {"id": 0, "config": {"enable": mode}}, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
This is not consistent with the hvac_mode property.
| ble_addr: str = self._config["addr"] | ||
| self._attr_unique_id = f"{ble_addr}-{self.key}" | ||
| name = self._config["name"] or f"shellyblutrv-{ble_addr.replace(":", "")}" | ||
| self._attr_name = name |
There was a problem hiding this comment.
According to https://developers.home-assistant.io/docs/core/entity/#entity-naming we should set this to None
| self._attr_name = name | |
| self._attr_name = None |
Note that we need to do this in the constructor otherwise it will be replaced by our base class naming logic.
| ) | ||
| _attr_hvac_modes = [HVACMode.OFF, HVACMode.HEAT] | ||
| _attr_target_temperature_step = RPC_THERMOSTAT_SETTINGS["step"] | ||
| _attr_temperature_unit = UnitOfTemperature.CELSIUS |
There was a problem hiding this comment.
Need to add here
_attr_has_entity_name = True
Breaking change
Proposed change
Add support for new device: Shelly BLU TRV
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: