Fix rainforest_raven closing device due to timeout #121905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When there's a timeout initializing the device, it's possible that a problem with the serial port is blocking the write operations, meaning that the
flush()
that's part of the call toclose()
might block. The device is already in a bad state, so we should just useabort()
to abandon the attempt so that we can try again. This will close the device without flushing the write buffer.I'm still not able to reproduce the reported problems with
rainforest_raven
at startup, but at least one of the backtraces I saw indicated that the call toawait device.close()
wasn't completing and eventually timed out. Though this change doesn't address why the device timed out to begin with, I'm hoping it mitigates the effects and allows Home Assistant to continue startup and try to open the device again later.The
abort()
method was introduced inaioraven
0.7.0, which this PR updates to:Upstream diff: https://github.com/cottsay/aioraven/compare/0.6.0..0.7.0
Upstream changelog: https://github.com/cottsay/aioraven/blob/0.7.0/CHANGELOG.md#070-2024-07-12
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: