Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override for work areas in Husqvarna Automower #120427

Merged
merged 25 commits into from
Jul 31, 2024

Conversation

Thomas55555
Copy link
Contributor

@Thomas55555 Thomas55555 commented Jun 25, 2024

Breaking change

Proposed change

With this service the user has the possibility to send the mower to a certain work area for a certain time.
This service is only created if at least one of the mowers supports workareas. If the service is called for a mower which isn't supported, there will be an ServiceValidationError

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@edenhaus
Copy link
Contributor

Drafting as additional work need to be done

@edenhaus edenhaus marked this pull request as draft June 26, 2024 13:56
@Thomas55555 Thomas55555 marked this pull request as ready for review June 26, 2024 19:04
@Thomas55555 Thomas55555 marked this pull request as draft June 26, 2024 19:10
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 6, 2024
@home-assistant home-assistant bot marked this pull request as draft July 31, 2024 16:37
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@edenhaus edenhaus marked this pull request as ready for review July 31, 2024 17:28
@home-assistant home-assistant bot requested a review from edenhaus July 31, 2024 17:28
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thomas55555 👍

@edenhaus edenhaus merged commit cc1a6d6 into home-assistant:dev Jul 31, 2024
22 checks passed
@Thomas55555 Thomas55555 deleted the start_in_workarea branch July 31, 2024 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants