Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solax inverter model selector in config_flow to bypass discovery #115129

Closed

Conversation

brew-your-own
Copy link

@brew-your-own brew-your-own commented Apr 7, 2024

Proposed change

Add a selector for the type of Inverter in the solax integration config flow.
This will bypass the inverter discovery code which tends to crash some of the dongles out there.
This was made possible by release 3.1.0 in the upstream solax library which introduced a revamped
discovery code and the ability to only discovery a subset of all inverters, see
squishykid/solax#145

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • [x ] The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brew-your-own

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Apr 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 7, 2024 16:08
@home-assistant
Copy link

home-assistant bot commented Apr 7, 2024

Hey there @squishykid, mind taking a look at this pull request as it has been labeled with an integration (solax) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of solax can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign solax Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title solax: add Inverter model selector in config_flow to bypass discovery Add solax inverter model selector in config_flow to bypass discovery Apr 8, 2024
Copy link
Contributor

@Darsstar Darsstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it 😄

PS. you might want to remove the spaces before/after the xs in the Checklist section. Github isn't handling that correctly.

homeassistant/components/solax/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/solax/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/solax/__init__.py Show resolved Hide resolved
homeassistant/components/solax/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/solax/config_flow.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Darsstar Darsstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to click 'Request changes', not 'Approve'...

better handling of missing inverter config entry
multiple=false in config_flow for inverter selector
@brew-your-own
Copy link
Author

made a few more changes following your feedback, WDYT?
I could not make ALL_COMPLETED work on my installation, I think some inverters do not like it...

Copy link
Contributor

@Darsstar Darsstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Mind opening an issue on the solax repo about ALL_COMPLETED not working for you?

@Darsstar Darsstar mentioned this pull request Jun 5, 2024
20 tasks
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 6, 2024
@emontnemery
Copy link
Contributor

emontnemery commented Aug 2, 2024

@brew-your-own the PR has merge conflicts, can you fix them or rebase the PR and click the "Ready for review" button when done please?

@emontnemery emontnemery marked this pull request as draft August 2, 2024 12:11
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Aug 12, 2024
@frenck
Copy link
Member

frenck commented Sep 27, 2024

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

../Frenck

@frenck frenck closed this Sep 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants