EXUI-2058: Add error message on staffUI #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olusegz07
previously approved these changes
Jul 15, 2024
RiteshHMCTS
previously approved these changes
Jul 16, 2024
andywilkinshmcts
previously requested changes
Jul 16, 2024
| takeUntil(this.unsubscribe$), | ||
| tap((error) => { | ||
| this.staffSelectError = !!error; | ||
| this.staffSelectErrors = error ? { title: 'Staff error', description: error.errorDescription } : null; |
There was a problem hiding this comment.
I would use optional chaining on error?.errorDescription, or possibly a ternary:
error ? { title: 'Staff error', description: error.errorDescription ? error.errorDescription : "unknown error" } : null
There was a problem hiding this comment.
Added optional chaining and ternary
| return this.staffDataAccessService.fetchSingleUserById(route.params.id).pipe( | ||
| map((user) => StaffUser.from(user)) | ||
| tap((user:StaffUser) => console.log('User:', user)), |
There was a problem hiding this comment.
I don't think you should commit this console.log
There was a problem hiding this comment.
Oops, will remove
RiteshHMCTS
approved these changes
Jul 22, 2024
kasi-subramaniam
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2058
Change description
Add error message on staffUI