Code review comments resolved

hmcts · Jul 16, 2024 · 63f0454 · 63f0454
1 parent c920315
commit 63f0454
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/staff-administrator/containers/staff-users/staff-users.component.ts b/src/staff-administrator/containers/staff-users/staff-users.component.ts
@@ -28,7 +28,7 @@ export class StaffUsersComponent {
       takeUntil(this.unsubscribe$),
       tap((error) => {
         this.staffSelectError = !!error;
-        this.staffSelectErrors = error ? { title: 'Staff error', description: error.errorDescription } : null;
+        this.staffSelectErrors = error ? { title: 'Staff error', description: error?.errorDescription ? error?.errorDescription: 'An unknown error has occured' } : null;
       })
     )
       .subscribe();

diff --git a/src/staff-administrator/resolvers/staff-user-details-resolver.service.ts b/src/staff-administrator/resolvers/staff-user-details-resolver.service.ts
@@ -1,7 +1,7 @@
 import { Injectable } from '@angular/core';
 import { ActivatedRouteSnapshot } from '@angular/router';
 import { Store } from '@ngrx/store';
-import { catchError, map, tap } from 'rxjs/operators';
+import { catchError, map } from 'rxjs/operators';
 import { of } from 'rxjs';
 import { StaffUser } from '../models/staff-user.model';
 import { StaffDataAccessService } from '../services/staff-data-access/staff-data-access.service';
@@ -19,7 +19,6 @@ export class StaffUserDetailsResolverService {
   public resolve(route?: ActivatedRouteSnapshot) {
     this.store.dispatch(new ResetStaffSelect());
     return this.staffDataAccessService.fetchSingleUserById(route.params.id).pipe(
-      tap((user:StaffUser) => console.log('User:', user)),
       map((user) => StaffUser.from(user)),
       catchError((error) => {
         this.store.dispatch(new SetError(error.error));