Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dfr 3175 CT controller postcode field not mandatory amend application details #1775

Merged
merged 31 commits into from
Jul 22, 2024
Merged

Dfr 3175 CT controller postcode field not mandatory amend application details #1775

merged 31 commits into from
Jul 22, 2024

Commits on Jul 9, 2024

  1. Create controller

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a6e65f7 View commit details
    Browse the repository at this point in the history

  2. extend basecontroller

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    dc4227c View commit details
    Browse the repository at this point in the history

  3. add postmap for /amend-application-app-sol

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    88fd07b View commit details
    Browse the repository at this point in the history

  4. add postmap for /amend-application-app

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1f2531c View commit details
    Browse the repository at this point in the history

  5. add postmap for /amend-application-res-sol

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ebf3902 View commit details
    Browse the repository at this point in the history

  6. check applicant postcode and solicitor postcode methods

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2890432 View commit details
    Browse the repository at this point in the history

  7. check respondent postcode and respondent solicitor postcode method

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    baab5f3 View commit details
    Browse the repository at this point in the history

  8. Call validation methods

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    09b60be View commit details
    Browse the repository at this point in the history

  9. Add descriptions

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    16f3622 View commit details
    Browse the repository at this point in the history

  10. rename methods

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f7a8c13 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Add test data

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0150e90 View commit details
    Browse the repository at this point in the history

  2. Add unit tests to cover errors for each page

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    29d0d9f View commit details
    Browse the repository at this point in the history

  3. Add unit tests to cover valid postcodes

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e80f13c View commit details
    Browse the repository at this point in the history

  4. Use constants instead

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    08a09a3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into DFR-3175-new-controller-Postcode-field-not… 

    …-mandatory---Amend-application-details
    @hamzahtahirhmcts
    hamzahtahirhmcts authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    4b2ed03 View commit details
    Browse the repository at this point in the history

  6. Add new line

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8984129 View commit details
    Browse the repository at this point in the history

  7. Add validation for postalService

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    2e125d6 View commit details
    Browse the repository at this point in the history

  8. Remove the initializer

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    26f67a8 View commit details
    Browse the repository at this point in the history

  9. rename to amend-application-validate-applicant-solicitor-address

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d91e97a View commit details
    Browse the repository at this point in the history

  10. rename to amend-application-validate-applicant-address

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    5457097 View commit details
    Browse the repository at this point in the history

  11. rename to amend-application-validate-respondent-solicitor

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    1f1f8f5 View commit details
    Browse the repository at this point in the history

  12. use requireNonNull

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    59c9e61 View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'origin/DFR-3175-new-controller-Postcode… 

    …-field-not-mandatory---Amend-application-details' into DFR-3175-new-controller-Postcode-field-not-mandatory---Amend-application-details
    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    6d9722d View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Mock postalService and finremCaseDetailsMapper

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0a0c58b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into DFR-3175-new-controller-Postcode-field-not… 

    …-mandatory---Amend-application-details
    @hamzahtahirhmcts
    hamzahtahirhmcts authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    f50e175 View commit details
    Browse the repository at this point in the history

  3. Add missing test case

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    caf242c View commit details
    Browse the repository at this point in the history

  4. Fix SonarCloud issues

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    510f05b View commit details
    Browse the repository at this point in the history

  5. Fix SonarCloud issues

    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    113ff3c View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/DFR-3175-new-controller-Postcode… 

    …-field-not-mandatory---Amend-application-details' into DFR-3175-new-controller-Postcode-field-not-mandatory---Amend-application-details
    @hamzahtahirhmcts
    hamzahtahirhmcts committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    04b7715 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'master' into DFR-3175-new-controller-Postcode-field-not… 

    …-mandatory---Amend-application-details
    @hamzahtahirhmcts
    hamzahtahirhmcts authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    bdfe056 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'master' into DFR-3175-new-controller-Postcode-field-not… 

    …-mandatory---Amend-application-details
    @hamzahtahirhmcts
    hamzahtahirhmcts authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    48d3c3c View commit details
    Browse the repository at this point in the history