Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dfr 3175 CT controller postcode field not mandatory amend application details #1775

Merged
merged 31 commits into from
Jul 22, 2024
Merged

Dfr 3175 CT controller postcode field not mandatory amend application details #1775

merged 31 commits into from
Jul 22, 2024

Conversation

hamzahtahirhmcts
Copy link
Contributor

Jira link (if applicable)

DFR-3175

Change description

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@hamzahtahirhmcts hamzahtahirhmcts marked this pull request as ready for review July 11, 2024 10:33
ptrelease
ptrelease previously approved these changes Jul 11, 2024
View reviewed changes
@ptrelease ptrelease self-requested a review July 11, 2024 12:10
@hamzahtahirhmcts
use requireNonNull
59c9e61
@hamzahtahirhmcts
Merge remote-tracking branch 'origin/DFR-3175-new-controller-Postcode…
6d9722d 
…-field-not-mandatory---Amend-application-details' into DFR-3175-new-controller-Postcode-field-not-mandatory---Amend-application-details
@hamzahtahirhmcts hamzahtahirhmcts changed the title Dfr 3175 new controller postcode field not mandatory amend application details Dfr 3175 CT controller postcode field not mandatory amend application details Jul 11, 2024
@hamzahtahirhmcts
Add missing test case
caf242c
@hamzahtahirhmcts
Fix SonarCloud issues
510f05b
@hamzahtahirhmcts
Fix SonarCloud issues
113ff3c
@hamzahtahirhmcts
Merge remote-tracking branch 'origin/DFR-3175-new-controller-Postcode…
04b7715 
…-field-not-mandatory---Amend-application-details' into DFR-3175-new-controller-Postcode-field-not-mandatory---Amend-application-details
so99y
so99y approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@so99y so99y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamzahtahirhmcts hamzahtahirhmcts merged commit 85e2582 into master Jul 22, 2024
5 checks passed
@hamzahtahirhmcts hamzahtahirhmcts deleted the DFR-3175-new-controller-Postcode-field-not-mandatory---Amend-application-details branch July 22, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawudgovuk dawudgovuk dawudgovuk left review comments

@so99y so99y so99y approved these changes

@jthmcts jthmcts jthmcts approved these changes

@al-hmcts al-hmcts al-hmcts approved these changes

@ptrelease ptrelease Awaiting requested review from ptrelease

Assignees
No one assigned
Labels
ns:financial-remedy prd:finrem
Projects
None yet
Milestone
No milestone
6 participants
@hamzahtahirhmcts @ptrelease @so99y @jthmcts @dawudgovuk @al-hmcts