Skip to content

Conversation

@usagi32
Copy link

@usagi32 usagi32 commented Oct 24, 2024

solves #1813

This will provide extra information for a transaction which is replaced by another. This can be used for replace-by-fee or maybe replace-across-fork but not sure though if replace-across-fork gives a new_txid or uses the previous one.

Nevertheless, @zone117x

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

@usagi32
Copy link
Author

usagi32 commented Oct 24, 2024

There is a requirement in the stacks core repo to be merged for this pull

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the very extensive delay @usagi32 , left a few comments. After that it LGTM

exports.up = pgm => {
pgm.addColumn('mempool_txs', {
replacing_txid: {
type: 'string',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be bytea

type_id: DbTxTypeId;
anchor_mode: DbTxAnchorMode;
status: DbTxStatus;
replacing_txid: string | null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PgBytea | null

@rafaelcr rafaelcr closed this May 2, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in API Board May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants