feat: add replaced_by_tx_id to replaced mempool transactions #2271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://stacks-blockchain-1ht0fcc46-hirosystems.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
rafaelcr
changed the title
rafaelcr
commented
May 21, 2025
| @@ -2129,8 +2207,8 @@ describe('mempool tests', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('prunes transactions with nonces that were already confirmed', async () => { | |||
| // Initial block | |||
| test('prunes and restores replaced-by-fee transactions', async () => { | |||
There was a problem hiding this comment.
@zone117x this is the main test of the new functionality
zone117x
reviewed
May 22, 2025
|
@zone117x thanks, I've tested locally but the next step will be to deploy this PR to dev and then staging to perform some load tests |
zone117x
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs multiple checks to make sure we trace transactions that are replaced by fee correctly:
replaced_by_tx_idkey to dropped mempool transaction responses that will include another transaction ID if this represents an RBF operation.new_tx_idfield from Stacks core when included on dropped mempool messagesReplaces #2141
Fixes #1813