-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transferring 16 emojis, mainly Spain subdivision flags (April 2024) #495
Conversation
Git file diff still says that "extras-openmoji.csv" is a binary file when it has it's binary flag disabled tho... Idk why that is
@xavizardKnight Many thanks for this! Wow! Comments:
Hence besides the "GO", the rest seems to be ready to go. Could you tweak the "GO" a bit further and the merge everything on one go ... or happy to tinker with the GO in a sperate PR so that we can merge the rest asap. Up to you. |
Then probably is a glitch on my end. If everything is fine in your end; then it's okay.
The original Golang icon has the Go letters in a big, wide and round font; maybe we could try recreating said letters instead of using the OpenMoji font. Said original logo font would probably not result in the inside of the G being filled black, and would probably fix the weird outline. The Golang icon has been the hardest of all the emojis in this PR, I had several ideas for how to do it, and none of those ideas (including the design in this PR) fully satisfy me, so I'm open to exploring more ideas or revisit the old ones I had. As to better test it without delaying the inclusion of the rest of the emojis here, I'll remove the Golang emoji and its associated metadata from this PR and create a new draft PR with only the Golang emoji. This way we will be able to redesign it more calmly. |
…ill be readded in an another PR for its redesign)
Golang has been removed from this PR. I'll open a new draft PR after you merge this one, as to avoid potential merge conflicts with the metadata. |
@xavizardKnight Great!! Merged! ❤️ |
Heyas! This is the PR for transferring the next batch of 16 emojis that I've been talking in some issues lately, including Spain subdivisions and four more brand icons. This time, I've written the correct month on the branch name, that's already an improvement! xD
Included emojis in this PR:
Merging this commit will close issue #416; as with this PR, all the subdivision flags of Spain will be done!
Issue #468 could also be closed. As I've debated in said issue that because of attribution requirements, not all the popular programming icons can be added. This issue implements the Dotnet, Kotlin and Golang icons, which are all public domain as far as I know; the Ruby icon is also here for it's dual meaning of programming language and gemstone.
A few notes:
npm run generate-data-tables
command gave me errors because I've messed up the formatting in the CSV files. I managed to fix it and generate the datatables, but the git diff of "extras-openmoji.csv" seems to be showing that is a binary file, which I think is not what it should be, and removing the executable flag doesn't seem to fix it… The big resulting openmoji.csv and openmoji.json files seem to be alright at least.Please let me know if something needs to be changed before merging this PR.
Thank you and have a nice day!