Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transferring 16 emojis, mainly Spain subdivision flags (April 2024) #495

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

xavizardKnight
Copy link
Contributor

Heyas! This is the PR for transferring the next batch of 16 emojis that I've been talking in some issues lately, including Spain subdivisions and four more brand icons. This time, I've written the correct month on the branch name, that's already an improvement! xD

Included emojis in this PR:

  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0061-E006E-E007F.svg (Andalusia ES-AN)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0063-E006E-E007F.svg (Canary Islands ES-CN)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0063-E0062-E007F.svg (Cantabria ES-CB)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0063-E006C-E007F.svg (Castile and León ES-CL)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0063-E006D-E007F.svg (Castile La Mancha ES-CM)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0063-E0065-E007F.svg (Ceuta ES-CE)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0065-E0078-E007F.svg (Extremadura ES-EX)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0067-E0061-E007F.svg (Galicia ES-GA)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E0072-E0069-E007F.svg (La Rioja ES-RI)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E006D-E0064-E007F.svg (Madrid ES-MD)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E006D-E006C-E007F.svg (Melilla ES-ML)
  • extras-unicode/subdivision-flag/1F3F4-E0065-E0073-E006E-E0063-E007F.svg (Navarre ES-NC)
  • extras-openmoji/brand/E04C.svg (Dotnet / .NET programming framework logo)
  • extras-openmoji/brand/E04D.svg (Golang programming language logo)
  • extras-openmoji/brand/E04E.svg (Kotlin programming language logo)
  • extras-openmoji/brand/E04F.svg (Ruby programming language logo)

Captura de pantalla a 2024-04-08 18-46-08

Merging this commit will close issue #416; as with this PR, all the subdivision flags of Spain will be done!

Issue #468 could also be closed. As I've debated in said issue that because of attribution requirements, not all the popular programming icons can be added. This issue implements the Dotnet, Kotlin and Golang icons, which are all public domain as far as I know; the Ruby icon is also here for it's dual meaning of programming language and gemstone.

A few notes:

  • The Canary Islands flag (1F3F4-E0065-E0073-E0063-E006E-E007F.svg) is also here. This flag has two Unicode sequences, a CN and a ES-CN. The Canary Islands flag in this PR responds to the ES-CN sequence, as the CN is already in OpenMoji (🇮🇨). As to distinguish it from the already existing OpenMoji design, the flag of this PR has the coat of arms in it.
  • I've had a few problems with the CSV data files, where the npm run generate-data-tables command gave me errors because I've messed up the formatting in the CSV files. I managed to fix it and generate the datatables, but the git diff of "extras-openmoji.csv" seems to be showing that is a binary file, which I think is not what it should be, and removing the executable flag doesn't seem to fix it… The big resulting openmoji.csv and openmoji.json files seem to be alright at least.
  • The golang icon (E04D) dark mode white outline is inconsistent. The thickness of the white outline is double the bigger than what it should be. I assume that this might be caused due to the peculiar construction of the emoji, where there are two instances of the "GO" letters, a thick black one for the outline, and a thin blue on top for the colouring; all of that on the color-foreground layer. I assume that this might be causing confusion to the outline script.

2024-04-09_00-18

Please let me know if something needs to be changed before merging this PR.

Thank you and have a nice day!

@b-g
Copy link
Member

b-g commented Apr 11, 2024

@xavizardKnight Many thanks for this! Wow!

Comments:

  • E04D.svg I find it not ideal that the G is "filled" on the inside all black, whereas the O is not. Maybe simply the "GO" slightly bigger that there is enough space to have some white on the inside with both letters? cc @dnlutz any advice how to deal with this?
  • the extras-openmoji.csv seem to be fine, at least here in github and on my machine it looks good. Maybe a local git glitch on your end?

Hence besides the "GO", the rest seems to be ready to go. Could you tweak the "GO" a bit further and the merge everything on one go ... or happy to tinker with the GO in a sperate PR so that we can merge the rest asap. Up to you.

@xavizardKnight
Copy link
Contributor Author

the extras-openmoji.csv seem to be fine, at least here in github and on my machine it looks good. Maybe a local git glitch on your end?

Then probably is a glitch on my end. If everything is fine in your end; then it's okay.

Hence besides the "GO", the rest seems to be ready to go. Could you tweak the "GO" a bit further and the merge everything on one go ... or happy to tinker with the GO in a sperate PR so that we can merge the rest asap. Up to you.

The original Golang icon has the Go letters in a big, wide and round font; maybe we could try recreating said letters instead of using the OpenMoji font. Said original logo font would probably not result in the inside of the G being filled black, and would probably fix the weird outline.

The Golang icon has been the hardest of all the emojis in this PR, I had several ideas for how to do it, and none of those ideas (including the design in this PR) fully satisfy me, so I'm open to exploring more ideas or revisit the old ones I had.

As to better test it without delaying the inclusion of the rest of the emojis here, I'll remove the Golang emoji and its associated metadata from this PR and create a new draft PR with only the Golang emoji. This way we will be able to redesign it more calmly.

…ill be readded in an another PR for its redesign)
@xavizardKnight
Copy link
Contributor Author

Golang has been removed from this PR.

I'll open a new draft PR after you merge this one, as to avoid potential merge conflicts with the metadata.

@b-g b-g merged commit 5380ba3 into hfg-gmuend:master Apr 12, 2024
1 check passed
@b-g
Copy link
Member

b-g commented Apr 12, 2024

@xavizardKnight Great!! Merged! ❤️

This was referenced Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants