Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's go: Golang #498

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Let's go: Golang #498

merged 6 commits into from
Jun 18, 2024

Conversation

xavizardKnight
Copy link
Contributor

Let's talk about the Golang icon.

I've pushed 5 versions of the Golang icon on the /src/ folder. These are just tests, and the final emoji will be moved to the correct place when finished.

2024-04-12_18-31

The original emoji that I presented in PR #495 is golang-smaller.svg. golang-bigger.svg is the same, but bigger (following your suggestion on the original PR of making the letters bigger). golang-blue-smaller.svg and golang-blue-bigger.svg are the same as the non-blue ones, but without the black outline at the GO letters. golang-original.svg is using the letters of the original logo instead of the OpenMoji font. The original has a line between the G and O, but I think removing it is better in this case.

Which one do you prefer the most? You should have read and write access to this branch, so feel free to experiment how you wish.

Once we decide on a version, I'll rename it, move it to the correct place, remove the others and readd the metadata.

Related with issue #468 and PR #495.

@dnlutz
Copy link
Contributor

dnlutz commented Apr 15, 2024

My favourite is golang-original.svg. It looks more dynamic than the upright OpenMoji letters so I would suggest to go for this one. Thank you!

@b-g
Copy link
Member

b-g commented Apr 15, 2024

I agree with Daniel ... but @xavizardKnight what do you think?

@b-g
Copy link
Member

b-g commented Apr 15, 2024

And many thanks for taking the time to prepare five versions! 👍 🙏

@xavizardKnight
Copy link
Contributor Author

Hi! Sorry for the super delay that I'm replying lately; I'm having a complicated year.

I agree that the version with the original lettering style looks better than the rest. Although it does look weird (at least for me) for an icon with such big letters to not use the OpenMoji font…

I'll start to tidy up this branch to prepare the original lettering style emoji to merge it soon. Will ping when everything's ready!

@b-g
Copy link
Member

b-g commented Jun 11, 2024

Great! Hope all is good on your end! Yes ... this will be a special case :)

@xavizardKnight
Copy link
Contributor Author

@b-g Branch ready to be merged! I think that there should be no merge conflicts…

@xavizardKnight xavizardKnight marked this pull request as ready for review June 16, 2024 19:15
@b-g b-g merged commit aeee432 into hfg-gmuend:master Jun 18, 2024
1 check passed
@b-g
Copy link
Member

b-g commented Jun 18, 2024

@xavizardKnight That's great! Many thanks! + Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants