fix(studio): overlay jump, delete-all, split polish [9/10]#1191
Open
miguel-heygen wants to merge 5 commits into
Open
fix(studio): overlay jump, delete-all, split polish [9/10]#1191miguel-heygen wants to merge 5 commits into
miguel-heygen wants to merge 5 commits into
Conversation
This was referenced Jun 4, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 4, 2026
miguel-heygen
force-pushed
the
feat/keyframes-6-dynamic-keyframes
branch
from
6e391b2 to
eca150f
Compare
miguel-heygen
force-pushed
the
feat/keyframes-7-fixes-polish
branch
from
82a5989 to
6c8acf6
Compare
miguel-heygen
force-pushed
the
feat/keyframes-6-dynamic-keyframes
branch
from
eca150f to
dcbe8da
Compare
miguel-heygen
force-pushed
the
feat/keyframes-7-fixes-polish
branch
from
6c8acf6 to
790ef3f
Compare
…yBoxSizes guard - Fix overlay bounding box jump: reapplyBoxSizes now skips elements whose width/height are animated by GSAP (gsapAnimatesProperty check prevents studio CSS from overwriting GSAP interpolated values) - Delete All Keyframes removes entire animation (handleGsapDeleteAnimation) with fallback to first animation when no keyframed anim exists - Wire split clip through App → StudioPreviewArea → NLELayout → Timeline (onSplitElement prop, toolbar button, S hotkey, clip context menu) - Add onContextMenu to TimelineClip for right-click clip context menu
Sub-compositions (data-composition-src) cannot be meaningfully split — the clone would load the same source and fight for the same timeline. Block with a specific toast message and disable in the context menu.
miguel-heygen
force-pushed
the
feat/keyframes-7-fixes-polish
branch
from
790ef3f to
99fc9ee
Compare
miguel-heygen
force-pushed
the
feat/keyframes-6-dynamic-keyframes
branch
from
dcbe8da to
3a8e22f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gsapAnimatesPropertyguard preventsreapplyBoxSizesfrom overwriting GSAP-interpolated width/heighthandleGsapDeleteAnimationwith fallback)+175 LOC