feat(studio): split clip at playhead for media elements [7/10]#1189
Open
miguel-heygen wants to merge 1 commit into
Open
feat(studio): split clip at playhead for media elements [7/10]#1189miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This was referenced Jun 4, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9a94cd9 to
bc87ce5
Compare
0dbfe93 to
925397e
Compare
bc87ce5 to
55d81f3
Compare
925397e to
4711c17
Compare
55d81f3 to
1670e95
Compare
…otkey Add splitElementInHtml to core source mutation helpers — clones an element at the split time, adjusts data-start/data-duration/data-media-start for both halves, and inserts the clone after the original. Wire through: split-element API endpoint, handleTimelineElementSplit in useTimelineEditing, clip context menu (right-click → Split at Xs), toolbar split button, and S keyboard shortcut. Edge cases: locked/implicit clips blocked, media trim offset adjusted by playback rate, unique ID generation with collision avoidance, undo via edit history.
1670e95 to
6f66981
Compare
4711c17 to
32dd0bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
splitElementInHtmlto core source mutation — clones element, adjusts timing/media-startsplit-elementAPI endpointhandleTimelineElementSplithandler with media-only guardSkeyboard shortcut+245 LOC