Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom vendored Ruby URL #1406

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Allow custom vendored Ruby URL #1406

merged 3 commits into from
Dec 6, 2023

Conversation

mlarraz
Copy link
Contributor

@mlarraz mlarraz commented Nov 29, 2023

Lets us provide our own custom set of vendored Ruby runtimes.

Useful for things like building Ruby on different architectures than what Heroku supports, or with different compile flags.

Currently in use on our fork of this repo, but we'd like to merge it upstream.

Fixes #1164.

Lets us provide our own custom set of vendored Ruby runtimes.

Currently in use on our fork of this repo, but we'd like to merge it upstream.
@mlarraz mlarraz requested a review from a team as a code owner November 29, 2023 03:12
@schneems
Copy link
Contributor

schneems commented Dec 5, 2023

I think this would close #1164. Thanks for working on it!

@edmorley
Copy link
Member

edmorley commented Dec 6, 2023

Rather then review/merge #1409, lets merge this PR to make the credit/attribution clearer. We still need the separate non-forked PR for integration tests to run (since they use credentials not available to PRs from forks), however, we can take advantage of the fact that GitHub's status checks API associates a pass/fail result with a commit SHA256 and not a specific branch/remote, to let the successful CI test result from that PR carry across to this PR.

We needed one more change, which was the changelog addition, so I've pushed that to this PR from the other branch (which is possible since this PR has the Maintainers are allowed to edit this pull request option enabled).

I'll manually merge this PR now, since auto-merge was enabled on #1409, so if I had reviewed that PR it would have been auto-merged anyway.

@edmorley edmorley merged commit 9dc8ea4 into heroku:main Dec 6, 2023
2 checks passed
@mlarraz mlarraz deleted the mlarraz-patch-1 branch December 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUILDPACK_VENDOR_URL doesn't allow for using vendored Ruby since v201
3 participants