Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom vendored Node URL #1410

Closed
wants to merge 1 commit into from
Closed

Allow custom vendored Node URL #1410

wants to merge 1 commit into from

Conversation

mlarraz
Copy link
Contributor

@mlarraz mlarraz commented Dec 6, 2023

Follow-up to #1406

Lets us ship custom builds, targeting different platforms than the Heroku default.

This is slightly more complicated than the Ruby change, as the URL contains a lot of platform-specific information, as well as interpolates the Node version.

My solution is to allow for a variable in the URL that gets substituted with the version.

This allows for dynamic lookups just like normal, and avoids hardcoding to a single version.

Follow-up to #1406

Lets us ship custom builds, targeting different platforms than the
Heroku default.

This is slightly more complicated than the Ruby change, as the URL contains a lot of
platform-specific information, as well as interpolates the Node version.

My solution is to allow for a variable in the URL that gets substituted
with the version.

This allows for dynamic lookups just like normal, and avoids hardcoding to a single version.
@mlarraz mlarraz requested a review from a team as a code owner December 6, 2023 16:56
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Switching code review request from the Languages team alias to the Ruby language owner)

@edmorley edmorley requested a review from schneems January 15, 2024 11:21
@schneems
Copy link
Contributor

The best way to install a custom node binary would be to make a micro buildpack https://devcenter.heroku.com/articles/buildpack-api. If which node returns zero it indicates to the Ruby buildpack that we do not need to install a node version. In the future we are moving away from installing node with CNBs (not available on Heroku yet) and instead relying on heroku/node buildpack for that functionality https://github.com/heroku/buildpacks-ruby.

@schneems schneems closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants