Mj/file store helium proto

[michaeldjeffrey]

file-store Refactor: Separate Helium Proto Concerns

This refactor extracts helium-proto specific functionality from file-store into a new crate: file-store-helium-proto. The goal is to remove helium-proto as a dependency from file-store. file-store remains protobuf-specific (using prost), but now developers can use file-store with their own local protos without needing to import helium-proto. All Helium-specific protocol mappings and types are consolidated into file-store-helium-proto.

file-store Cleanup

Remove MsgBytes Trait

The MsgBytes trait has been removed from file-store. Previously, this trait existed to abstract over different message types that could be written to a FileSink. The trait had to be supplementally implemented for any types that wanted to use FileSinkWriteExt. Now FileSinkWriteExt can be used with any protobuf type that implements prost::Message.

Remove helium-proto Dependency

file-store no longer depends on helium-proto. As part of this change:

• UnknownEnumValue error now comes from prost instead of helium-proto
• All helium-proto specific mappings have been moved to file-store-helium-proto

General Cleanup

Several unused dependencies and code were removed:

• Removed csv dependency and related error variant
• Removed config dependency and ConfigError variant
• Removed unused error variants: JoinError, Shutdown
• Improved FileInfoPollerError to include context: {0} in error message
• Removed unused dependencies: clap, strum, strum_macros, blake3, beacon, humantime-serde

CLI Commands Moved

All CLI commands have been moved to file-store-helium-proto and now return anyhow::Result.

file-store-helium-proto

Structure

The new crate is organized into logical groupings that mirror the Helium network structure:

• iot/ - IoT-specific protocol mappings (beacon reports, witness reports, packets, valid/invalid PoC)
• mobile/ - Mobile-specific protocol mappings (coverage, sessions, speedtests, wifi heartbeats, bans, subscriber info, transfers)
• subscriber/ - Subscriber-specific mappings (verified mapping events, unique connections, usage counts)
• network_common/ - Cross-network shared types (entropy reports, reward manifests)
• file_type.rs - FileType enum moved from file-store
• traits/ - Helium-specific traits

Traits Moved

These traits were specific to helium-proto types have been moved to avoid orphan rules:

• MsgVerify - for verifying signed messages
• FileSinkWriteExt - extension trait for writing to file sinks with Helium-specific rollover and commit strategies
• MsgTimestamp - converting u64 <-> DateTime<Utc> for proto <-> domain struct mappings

The MsgTimestamp trait remains in file-store-helium-proto as traits::MsgTimestamp since it's used across multiple Helium proto types. Moving this trait created orphan rule issues initially, but these have been resolved by implementing the trait within the same crate that defines the types.

FileType Enum

The FileType enum has been moved from file-store to file-store-helium-proto since it's entirely Helium-specific.

CLI

The CLI (file-store-helium-proto binary) provides commands for working with Helium file-store data.
The print_json utility function has also been moved here since it's used by the CLI commands.

Codebase Updates

All downstream crates have been updated to use file-store-helium-proto for Helium-specific types and traits:

• ingest
• iot_config
• iot_packet_verifier
• iot_verifier
• mobile_config
• mobile_packet_verifier
• mobile_verifier
• poc_entropy
• price
• reward_index
• solana

Test Updates

In test files, you'll see imports like use file_store_helium_proto::coverage instead of shorter paths. This is intentional - many test files have local modules named coverage, mobile_session, etc. Using the fully qualified file_store_helium_proto:: prefix makes it immediately clear which types are from the library vs. local test helpers.

Import Changes

Here's an example of some common imports that may have changed.

Before:

use file_store::{
    entropy_report::EntropyReport,
    file_info_poller::FileInfoStream,
    file_sink::FileSinkClient,
    traits::{
        FileSinkCommitStrategy, FileSinkRollTime, FileSinkWriteExt,
        MsgTimestamp, TimestampDecode, TimestampEncode,
        MsgDecode, MsgVerify
    },
    DecodeError, Error, Result
};

After:

use file_store::{
    file_info_poller::FileInfoStream,
    file_sink::FileSinkClient,
    traits::{TimestampDecode, TimestampEncode},
    DecodeError, Error, Result
};
use file_store_helium_proto::{
    network_common::entropy_report::EntropyReport,
    traits::{
        FileSinkCommitStrategy, FileSinkRollTime, FileSinkWriteExt,
        MsgTimestamp, MsgVerify,
    },
};