smaller file store updates #1069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anything that can be turned into a string can now become a FileType. Attempting to remove the dependency between FileInfo and FileType.
It’s an extra layer of indirection that makes it hard to use other proto types with file-store. Originally MsgBytes had to be implemented for any type that wanted to use FileStoreWriteExt and every type had to have a manual implementation cecause of our lack of ability to provide a blanket impl for prost::Message. Almost literally everything implements prost::Message. We don’t lose any type safety because we still type our FileClients and the like with the protobuf type we expect to be writing.
trying to remove the hard dep on helium-proto for lib specific code.
This allows us to remove some unneeded err variants from file-store::Error.
file-store lib does not encode anything to JSON. If this err is needed it’s at the application level.
file-store the lib does not make clients from it’s settings, that all happens at the application level. The config::ConfigError can be mapped at that level.
michaeldjeffrey
requested review from
bbalser,
connormck333,
jeffgrunewald,
kurotych,
macpie and
madninja
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1068 is a big change.
This PR is a smaller subset that I think is still good while the larger structure of
file-storeis talked about.MsgBytescsvandhumantime-serdeanyhow::Resultinstead offile_store::Resultserde_json::Errorprost::Messageinstead ofhelium_proto::Message, a nicer separation of depsInto<FIleInfo>for anything that can turn itself into a stringFileTypeforFileInfofile_store::Error::JoinErrorused by unusedstart()function (also removed)file_store::Error::Configused when constructingfile_store::Settings, but not in the library code pathfile_store::Error::Shutdownunused