FE-21: Design System: Add checkbox #7886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/libs
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
14 tasks
kube
changed the title
kube
commented
Oct 19, 2025
This was referenced Oct 20, 2025
kube
changed the base branch from
H-5425-bezel-width-greater-than-radius
to
graphite-base/7886
kube
changed the base branch from
graphite-base/7886
to
H-5425-bezel-width-greater-than-radius
kube
changed the base branch from
H-5425-bezel-width-greater-than-radius
to
graphite-base/7886
This was referenced Oct 20, 2025
github-actions
bot
added
area/deps
kube
force-pushed
the
graphite-base/7886
branch
from
e372d7b to
55e19bd
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
CiaranMn
previously approved these changes
Oct 29, 2025
Member
CiaranMn
left a comment
CiaranMn
left a comment
There was a problem hiding this comment.
Looks good apart from one doc line, also linting needs fixing. Can reapprove when linting fixed
libs/@hashintel/ds-components/src/components/Checkbox/checkbox.stories.tsx
Outdated
Show resolved
Hide resolved
kube
commented
Oct 29, 2025
Comment on lines
+27
to
+31
| // No matching props could be found for these Figma properties: | ||
| // "showLabel": figma.boolean('_showLabel'), | ||
| // "label": figma.string('label'), | ||
| // "showIcon": figma.boolean('_showIcon'), | ||
| // "icon": figma.instance('Icon') |
Collaborator
Author
There was a problem hiding this comment.
These should be discussed with @ciaranha.
I keep it in the Code Connect file, so we see what the API looks like on Figma, and we can possibly update it there.
github-actions
bot
dismissed
CiaranMn’s stale review
Your organization requires reapproval when changes are made, so Graphite has dismissed approvals. See the output of git range-diff at https://github.com/hashintel/hash/actions/runs/19021509359
CiaranMn
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Add Checkbox component
🔍 What does this change?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
❓ How to test this?