H-5705: Design System: Use PandaCSS Recipes and update LLMs instructions #8084
Conversation
…ses from components
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
area/infra
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kube
changed the title
kube
changed the title
indietyp
left a comment
indietyp
left a comment
There was a problem hiding this comment.
overall lgtm, just have some minor stylistic comments for the states, that may (or may not) be helpful. Might make sense to create our own _unchecked selector if we end up going that route.
| }, | ||
|
|
||
| // Disabled state | ||
| "&[data-disabled]": { |
There was a problem hiding this comment.
| "&[data-disabled]": { | |
| _disabled: { |
| }, | ||
|
|
||
| // Invalid state | ||
| "&[data-invalid]": { |
There was a problem hiding this comment.
| "&[data-invalid]": { | |
| _invalid: { |
| flexShrink: "0", | ||
|
|
||
| // Hover state (unchecked) | ||
| "&[data-state='unchecked']:hover:not([data-disabled])": { |
There was a problem hiding this comment.
data-state is already covered, so you can use: _checked and _indeterminate.
There was a problem hiding this comment.
not doesn't seem have a way to be expressed :/
There was a problem hiding this comment.
Not sure of how to do composition with their "shortcut keys"?
🌟 What is the purpose of this PR?
css()outside of components for better readability.cva()when needed.Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: