Skip to content

Added comments about github and 3rd-party providers. #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,5 @@ Additionally, the agent must also be able to communicate with any services requi
| releases.hashicorp.com | tcp/443, HTTPS | Outbound | Updating agent components and downloading Terraform binaries |
| archivist.terraform.io | tcp/443, HTTPS | Outbound | Blob Storage |
| agents.terraform.io | tcp/7146, TCP | Outbound | Agent RPC interface (currently used for request forwarding only) |

Additionally, outbound traffic to *.github.com should be allowed if any 3rd-party providers are used. These can be pulled in implicitly by resource definitions, or explicitly by provider configurations added to the HCL code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryk-rychlik Could you add this to the table above? I feel like it'd make sense with everything above! Something like this:

| github.com  | ? | Outbound       | Required if you are using a 3rd party provider while defining resources or in configuring providers. |

I'm not sure what the prot/protocal would be though?

Loading