Skip to content

Added comments about github and 3rd-party providers. #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

henryk-rychlik
Copy link

This wasn't explicitly spelled out previously. Only implied by the following sentence:

Additionally, the agent must also be able to communicate with any services required by the Terraform code it is executing.

@henryk-rychlik henryk-rychlik requested a review from a team as a code owner June 13, 2025 21:23
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

1 similar comment
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

github-actions bot commented Jun 13, 2025

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Fri Jun 13 21:43:30 UTC 2025
Unified Docs API ✅ Ready (Inspect) Visit Preview Fri Jun 13 21:38:21 UTC 2025

Copy link

Broken Link Checker

No broken links found! 🎉

@@ -69,3 +69,5 @@ Additionally, the agent must also be able to communicate with any services requi
| releases.hashicorp.com | tcp/443, HTTPS | Outbound | Updating agent components and downloading Terraform binaries |
| archivist.terraform.io | tcp/443, HTTPS | Outbound | Blob Storage |
| agents.terraform.io | tcp/7146, TCP | Outbound | Agent RPC interface (currently used for request forwarding only) |

Additionally, outbound traffic to *.github.com should be allowed if any 3rd-party providers are used. These can be pulled in implicitly by resource definitions, or explicitly by provider configurations added to the HCL code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henryk-rychlik Could you add this to the table above? I feel like it'd make sense with everything above! Something like this:

| github.com  | ? | Outbound       | Required if you are using a 3rd party provider while defining resources or in configuring providers. |

I'm not sure what the prot/protocal would be though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants