[WIP] [Project Solar / Phase 1 / Tokens Pipeline] Add $modes support to tokens pipeline
#3239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
didoo
changed the title
$modes support to tokens pipeline$modes support to tokens pipeline
5 tasks
didoo
force-pushed
the
project-solar/phase-1/HDS-5216_modes/modes-feature-branch
branch
from
bcb7219 to
fa4bad2
Compare
…ith references to Carbon tokens, for testing
…h missing references when using Carbon tokens with theming logic
…ng references and filtering when theming is applied
didoo
force-pushed
the
project-solar/phase-1/HDS-5216_modes/modes-pipeline-implementation
branch
from
1803ce4 to
66b876e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
This is the implementation PR for adding support to co-located
$modesvalues in the design tokens JSON files, the processing of such values, and the generation of distinct "themed" CSS files in output, with different formats.This is built on top of #3238
🛠️ Detailed description
📸 Screenshots
🔗 External links
Jira ticket: HDS-XXX
Figma file: [if it applies]
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.