Skip to content

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Sep 30, 2025

📌 Summary

This is built on top of #3239 and is based on the initial spike done by @alex-ju in #3235

🛠️ Detailed description

In this PR I have:

  • re-organized the components' Sass files architecture to split the common part in a separate file, and add two new Sass files that include theming via CSS selectors or via prefers-color-scheme
  • update the Rollup configuration to process multiple Sass files and generate distinct CSS files in output:
    • design-system-components.css - current file for HDS components
    • design-system-components-theming-with-css-selectors.css - new file for theming via CSS selectors
    • design-system-components-theming-with-prefers-color-scheme.css - new file for theming via prefers-color-scheme

Then, after discussion and agreement with @alex-ju, I have moved also the existing compilation of the design-system-components.scss and design-system-power-select-overrides.scss files to our custom plugin, so we can remove rollup-plugin-scss as dev-dependency

  • in the new configuration, the design-system-power-select-overrides.scss is not only copied in the dist folder, but also compiled to .css (and a .map file is generated)

⚠️ TODO

  • create a Jira ticket for the future, to look at the code of rollup-plugin-scss and see if there is something else that we want to port from their implementation into our custom plugin logic

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-5505


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@didoo didoo requested review from alex-ju and Copilot September 30, 2025 11:13
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Error Error Oct 2, 2025 11:44am
hds-website Error Error Oct 2, 2025 11:44am

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the Sass architecture for the Helios Design System components to support theming capabilities. It creates a foundation for generating multiple CSS builds with different theming strategies while maintaining the existing component functionality.

Key changes:

  • Reorganizes Sass files to separate common components from theming-specific configurations
  • Updates Rollup configuration to support multiple CSS output files with custom SCSS compilation
  • Creates new themed CSS variants using CSS selectors and prefers-color-scheme approaches

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/components/src/styles/components/index.scss New centralized index file importing all component SCSS files
packages/components/src/styles/@hashicorp/design-system-components.scss Refactored to use new components index and updated token paths
packages/components/src/styles/@hashicorp/design-system-components-theming-with-prefers-color-scheme.scss New themed variant using prefers-color-scheme media queries
packages/components/src/styles/@hashicorp/design-system-components-theming-with-css-selectors.scss New themed variant using CSS selectors
packages/components/rollup.config.mjs Updated with custom SCSS compilation function and multiple output configurations

@didoo didoo force-pushed the project-solar/phase-1/HDS-5505_components/modes-css-compilation branch from 75bc4b6 to b258e2e Compare September 30, 2025 13:39
@didoo didoo changed the title [WIP] [Project Solar / Phase 1 / Themed CSS for HDS components] Update Rollup configuration to process multiple Sass files and re-organize the components' Sass architecture to include theming [WIP] [Project Solar / Phase 1 / Themed CSS for HDS components] Multi-file Rollup configuration and Sass processing Sep 30, 2025
@didoo didoo changed the title [WIP] [Project Solar / Phase 1 / Themed CSS for HDS components] Multi-file Rollup configuration and Sass processing [WIP] [Project Solar / Phase 1 / Themed CSS for HDS components] Rollup configuration and Sass processing for multiple files Sep 30, 2025
@didoo didoo force-pushed the project-solar/phase-1/HDS-5216_modes/modes-pipeline-implementation branch from 1803ce4 to 66b876e Compare September 30, 2025 14:51
@didoo didoo force-pushed the project-solar/phase-1/HDS-5505_components/modes-css-compilation branch from 67f8499 to d4cd0c3 Compare September 30, 2025 14:51
@alex-ju alex-ju mentioned this pull request Oct 1, 2025
5 tasks
@didoo didoo force-pushed the project-solar/phase-1/HDS-5216_modes/modes-pipeline-implementation branch from 66b876e to 1a855c1 Compare October 2, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants