Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Actions checkout and setup-node #2024

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 12, 2023

Removes the depreciation errors like at https://github.com/handlebars-lang/handlebars.js/actions/runs/6997734302

Before creating a pull-request, please check https://github.com/handlebars-lang/handlebars.js/blob/master/CONTRIBUTING.md first.

Generally we like to see pull requests that

  • Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • Have good commit messages
  • Have tests
  • Have the typings (types/index.d.ts) updated on every API change. If you need help, updating those, please mention that in the PR description.
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
  • Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

@cclauss cclauss changed the base branch from master to 4.x December 12, 2023 21:12
@cclauss cclauss changed the base branch from 4.x to master December 12, 2023 21:13
cclauss added a commit to cclauss/handlebars.js that referenced this pull request Dec 12, 2023
@jaylinski
Copy link
Member

Thanks!

@jaylinski jaylinski merged commit 25c696b into handlebars-lang:master Dec 13, 2023
7 checks passed
jaylinski pushed a commit that referenced this pull request Dec 13, 2023
@cclauss cclauss deleted the patch-1 branch December 14, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants